Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 37 and add 311 to test #240

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

djs0109
Copy link
Contributor

@djs0109 djs0109 commented Feb 6, 2024

closes #211

@djs0109
Copy link
Contributor Author

djs0109 commented Feb 13, 2024

We currently cannot support python3.12 in CI/CD tests

@djs0109 djs0109 requested a review from RCX112 February 13, 2024 15:56
@djs0109
Copy link
Contributor Author

djs0109 commented Feb 13, 2024

@RCX112 it seems like, there are not changes required for the upgrading

@RCX112
Copy link
Collaborator

RCX112 commented Feb 14, 2024

@djs0109 Yes, I checked all the packages for Python 3.11 and 3.12. The only critical ones are igraph~=0.9.8 and matplotlib~=3.5.3. In the Image you use in the CI-Pipeline igraph~=0.9.8 will not be installed and I guess matplotlib~=3.5.3 works in this case, because an Image like python:3.11 is used (but for example it doesn't work for the Image python:3.11-slim or python:3.11-alpine). In general we should be careful with these two versions when using Python 3.11 and 3.12. The best and easiest solution is to update both packages to a newer version when using 3.11 and 3.12. For example igraph~=0.11.3 and matplotlib~=3.8.2 works pretty fine for me.

@RCX112
Copy link
Collaborator

RCX112 commented Feb 14, 2024

The tests also run through for 3.11 and 3.12 but I think they don't depend on these two packages

Copy link
Collaborator

@RCX112 RCX112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djs0109
Copy link
Contributor Author

djs0109 commented Feb 21, 2024

Actually I have added semantics as an option for installation. Therefore igraph will only be installed when users explicitly specify, see here. And so do matplotlib. @RCX112 How do you install filip? In our test environment, we use pip install -r requirements.txt. Therefore, all dependencies in requirement.txt are installed.

@RCX112
Copy link
Collaborator

RCX112 commented Feb 21, 2024

@djs0109 For testing I installed all the packages with pip install -r requirements.txt.

Copy link
Collaborator

@RCX112 RCX112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djs0109 Looks good for me. Shall we also uncomment igraph in the requirements.txt and change the version of it?

@djs0109 djs0109 changed the title chore: remove 37 and add 311 and 312 to test chore: remove 37 and add 311 to test Mar 5, 2024
@djs0109 djs0109 merged commit 68765e0 into master Mar 6, 2024
1 check passed
@djs0109 djs0109 deleted the 211-Python-version-upgrade-to-3-10-3-11-3-12 branch March 6, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python version upgrade to 3.10, 3.11, (3.12)
2 participants