feat: add mqtt internal url in tests #239
Conversation
There was a problem hiding this comment.
That is exactly what I mean with the MQTT subscriptions. More general, in the Issue #238 we would also need an internal URL for other FIWARE components such as the OCB, for example in
tests/clients/test_ngsi_v2_cb.py
Outdated
| @@ -533,6 +534,7 @@ def on_disconnect(client, userdata, reasonCode, properties=None): | |||
| cb_url=settings.CB_URL) | |||
| def test_notification(self): | |||
| mqtt_sub_url = settings.MQTT_BROKER_URL | |||
There was a problem hiding this comment.
I think I would rename mqtt_sub_url to mqtt_url because only the internal URL is the subscription URL.
There was a problem hiding this comment.
It has been changed now
|
@djs0109 If I checked everything correctly, the only missing thing is an internal cb_url for the timeseries test function which I mentioned on the top: |
|
@RCX112 I would rather not implement it, because this API has been deprecated in QL1.0.0 (see here orchestracities/ngsi-timeseries-api#493). I will open up another issue to test the capability with QL 1.0.0 and remove this test |
|
@RCX112 Could you check again, whether it is good to merge? |
djs0109
deleted the
238-Adding-a-second-Test-configuration-when-using-FIWARE-components-inside-Docker
branch
close #238