chore: make entity_type optional
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djs0109 before reviewing, please double check if you changed fuctions that may require the uniqueness, hence, the entity_type must be provided. |
|
@tstorek you are right, there were still some works to do. It should be ready for review now |
# Conflicts: # CHANGELOG.md # filip/clients/ngsi_v2/cb.py # tests/clients/test_ngsi_v2_cb.py
|
@tstorek no worry, I will then ask other reviewers ;) |
sbanoeon
reviewed
May 6, 2024
# Conflicts: # CHANGELOG.md # filip/clients/ngsi_v2/cb.py # tests/clients/test_ngsi_v2_cb.py
sbanoeon
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #168
@windrad6 As we previously discussed, we will make the
entity_typenot required for most of the functions