Skip to content

Commit

Permalink
build-and-push is limtied to once per pipeline workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
PicoCreator committed Aug 22, 2023
1 parent 51af911 commit c9bbc1a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 15 deletions.
14 changes: 0 additions & 14 deletions .github/workflows/docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,17 +109,3 @@ jobs:
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=gha,src=docker/env-cuda-11-8
cache-to: type=gha,mode=max

# Build and push Docker image with Buildx (don't push on PR)
# https://github.com/docker/build-push-action
- name: Build and push Docker image (github-worker-cuda-11-8)
id: build-and-push
uses: docker/build-push-action@v4
with:
context: "{{defaultContext}}:docker/github-worker-cuda-11-8"
push: ${{ github.event_name != 'pull_request' }} # Don't push on PR
tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME_LC }}:github-worker-cuda-11-8
# tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=gha,src=docker/github-worker-cuda-11-8
cache-to: type=gha,mode=max
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,9 @@ notebook/scratch/*
*/lightning_logs/
*/config.yaml

# Add back script files used in docker images
!docker/**/*.sh

# Add .github items
!.github/

Expand Down
5 changes: 4 additions & 1 deletion docker/env-cuda-11-8/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,7 @@ RUN pip3 install lightning==2.0.5 deepspeed==0.10.0 \

# Install the misc packages we might need for the various experiments
RUN pip3 install \
papermill aiocsv aiofiles
papermill aiocsv aiofiles

# Configure default dir, to the home directory
WORKDIR /root

0 comments on commit c9bbc1a

Please sign in to comment.