-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the ranking algorithm #2312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic! And good thinking adding the test assets to our pytests. See my one small comment about just deleting duplicate code instead of commenting it out
code/ARAX/ARAXQuery/ARAX_ranker.py
Outdated
if edge_key in edge_set_to_high_confidence: | ||
print(f"setting max confidence for edge_key: {edge_key}") | ||
edge.confidence = edge_confidence_manual_agent | ||
## comment code below because it is logically a duplicate code from above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about just deleting this?
Non-semmeddb direct “treats” should be ranked higher
More edges is better
Downweight text mining provider
Downweight semmeddb
Single drugbank edge better than multiple textmined edges