Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the ranking algorithm #2312

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Improve the ranking algorithm #2312

merged 8 commits into from
Jul 10, 2024

Conversation

chunyuma
Copy link
Collaborator

  • Improve the old ranking algorithm with the following few features:

Non-semmeddb direct “treats” should be ranked higher
More edges is better
Downweight text mining provider
Downweight semmeddb
Single drugbank edge better than multiple textmined edges

  • Add a few test cases for ARAX ranker

@chunyuma chunyuma requested review from dkoslicki and edeutsch July 10, 2024 17:10
Copy link
Collaborator

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks!

Copy link
Member

@dkoslicki dkoslicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! And good thinking adding the test assets to our pytests. See my one small comment about just deleting duplicate code instead of commenting it out

if edge_key in edge_set_to_high_confidence:
print(f"setting max confidence for edge_key: {edge_key}")
edge.confidence = edge_confidence_manual_agent
## comment code below because it is logically a duplicate code from above
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just deleting this?

@chunyuma chunyuma merged commit 16af13f into master Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants