Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLein #10

Open
wants to merge 130 commits into
base: main
Choose a base branch
from
Open

SLein #10

wants to merge 130 commits into from

Conversation

yogiwijaya777
Copy link

No description provided.

yogiwijaya777 and others added 30 commits December 7, 2023 16:23
@yogiwijaya777
Added MongoDB Completion
7061c88
@yogiwijaya777
Merge pull request #1 from yogiwijaya777/yogi
0da3852 
Added MongoDB Completion
@yogiwijaya777
Adding Folder/File Structure
713bb7d
@yogiwijaya777
Complete Todo & User model
3490ceb
@yogiwijaya777
USer Router completed
4d700d8
@yogiwijaya777
Todos Router Complete
a7d7c0c
@yogiwijaya777
Completing Router Index
a4368ee
@yogiwijaya777
Refactoring Todo Schema
7c2f26f
@yogiwijaya777
Setting up editorconfig
cb54aa2
@yogiwijaya777
Refactor All Files Following ESLint rules
143ea07
@yogiwijaya777
Adding createTask feature
ddda428
@yogiwijaya777
Adding Get All Users API
c4b430f
@yogiwijaya777
Adding Get User API
7c25b21
@yogiwijaya777
Adding Delete User API
c76880f
@yogiwijaya777
Adding Update User API
007f3b7
@yogiwijaya777
Adding TODOS API
e41dc7f
@yogiwijaya777
Merge pull request #2 from yogiwijaya777/yogi
054ae66 
Yogi
@yogiwijaya777
Starting Project fancy-todo-orm
e77f2ff
@yogiwijaya777
Merge pull request #3 from yogiwijaya777/yogi
c94a3a2 
Starting Project fancy-todo-orm
@yogiwijaya777
Setting up Prisma
b8171b8
@yogiwijaya777
Merge pull request #4 from yogiwijaya777/yogi
8acfd92 
Setting up Prisma
@yogiwijaya777
Setting up app.js and index.js
7c74450
@yogiwijaya777
Adding services file
e73a1cd
@yogiwijaya777
Setting up todo.service.js
75f5571
@yogiwijaya777
Setting up user.service.js
de3452a
@yogiwijaya777
Adding controllers file
f94aa78
@yogiwijaya777
Setting up user controller
0e58e3c
@yogiwijaya777
Setting up todo controller
a369921
@yogiwijaya777
Setting up routers
c744ac5
@yogiwijaya777
Push todo-fancy-orm
11c3621
@yogiwijaya777
queryLogic change
22f9ae1
@yogiwijaya777
refactor user service
f78b5ee
@yogiwijaya777
user.test POST
5b0eaa1
@yogiwijaya777
Merge pull request #22 from yogiwijaya777/yogi
537bd6e 
[27-01-2024]
@yogiwijaya777
GET user.testing complete
9b54ba8
@yogiwijaya777
GET:id Users and fix error GET
d8848ba
@yogiwijaya777
PATCH user.test complete
eab8a26
@yogiwijaya777
REFACTOR PATCH user.testing
6b3cf43
@yogiwijaya777
DELETE user testing completed
741e774
@yogiwijaya777
Merge pull request #23 from yogiwijaya777/yogi
b3622c8 
[28-01-2024] user.testing completed
@yogiwijaya777
order fixture and post first test
06296f4
@yogiwijaya777
Merge pull request #24 from yogiwijaya777/yogi
4765bb7 
order fixture and post first test
@yogiwijaya777
order test complete
b954711
@yogiwijaya777
Merge pull request #25 from yogiwijaya777/yogi
41c425e 
order test complete
@yogiwijaya777
orderItems logic and first test orderItems
d07a2ee
@yogiwijaya777
orderItem.test POST complete
7278980
@yogiwijaya777
GET ordeItem.testing complete
769374b
@yogiwijaya777
GET:ID, PATCH:ID, and adding more testing on POST
8b2379e
@yogiwijaya777
order.testing : PATCH refactor, DELETE ctesting Complete
9a9906c
@yogiwijaya777
refactor user authorization to admin, refactor error auth.test , all …
35d28ef 
…test complete
@yogiwijaya777
Create README.md
565a077
@yogiwijaya777
Update README.md
66081ae
@yogiwijaya777
documentation and serving bit ejs and css
90eb1f9
@yogiwijaya777
editing readme.md
8bf3ab6
@yogiwijaya777
Update README.md
be49acf
@yogiwijaya777
Merge pull request #27 from yogiwijaya777/yogi
531ed37 
Yogi
@yogiwijaya777
Update README.md
d178e66
zexoverz
zexoverz reviewed Feb 7, 2024
View reviewed changes
inventory-system/src/controllers/order.controller.js
Comment on lines +16 to +24
const filter = { total: req.query.total };
const options = {
take: req.query.take || 10,
page: req.query.page || 1,
sort: req.query.sort === 'latest' ? { date: 'desc' } : { date: 'asc' },
};

const orders = await orderService.queryOrders(filter, options);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice options filter, additional sorting gini lumayan kepake buat front end nyari data historical

zexoverz
zexoverz approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@zexoverz zexoverz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OrderItem overall good, Testing juga rapih semua gua liat. paling ini aja Slein. cobain Expect yang lain selain test status API nya.
soalnya masih banyak Testcase selain check status , response. (ini epxlore kalo ada waktu aja).

Documentation well played, gua ga nyangka lu implement swagger juga di IS. point+ banget sih ini.

untung serve EJS + CSS di dalam IS point++ juga. gua appreciate lu explore nya udah jauh.

ready buat group project ini. keep the good work Slein

@zexoverz
Copy link
Contributor

Congrats Slein, selamat atas kelulusannya di phase 1 🔥 🔥 🔥
lu termasuk devil, soalnya bantai 5 week tepat waktu. Progress belajar juga lumayan cepet, keliatan antusias lu buat explore sesuatu. sayang aja final project kurang lancar jadi ngaruh juga di final report lu.

overall nilai lu di phase 1 ada di angka 80%, penilaian ini base on:
-Logic Handling
-Explore
-Question Ask
-Learn Speed
-Task Submit

Review:
untuk handling backend lu udah bagus, explore juga lumayan cepet progressnya.
Task submit aman semua, paling final projectnya aja sih kurang lancar. banyak kesalahan teknis diawal.
next time kalau group project fokus MVP dlu ya, baru additional feature yang lain. soalnya yang gua nilai flow app nya.
buat nambah wawasan lagi, di banyakin porto backend nya ya Slein. cobain template prisma gua, explore backend" complex kayak e-commerce atau ticketing online. dan jangan lupa logic jangan sampe lepas, kalo bisa setiap minggu ngerjain 3-5 soal logic.

untuk open gate phase 2 nanti di umumin jadwalnya, standby aja.
Untuk mengisi liburan , bisa explore backend lagi kalau tertarik mau jadi backend developer :
-Explore Payment Gateway (Stripe)
-Explore Cache (redis)
-Explore Microservice Architecture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zexoverz zexoverz zexoverz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yogiwijaya777 @zexoverz