Qt: Fix gl-gs-frame error in debug builds #16614
Open
+41
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-11
reviewed
Jan 24, 2025
| { | ||
| const auto context = static_cast<GLContext*>(ctx); | ||
|
|
||
| if (context->handle->makeCurrent(context->surface)) |
There was a problem hiding this comment.
Nope. This is wrong.
GLRC makeCurrent means "make this context the current one on this thread".
We don't want it attached to main thread, we want it attached to the caller. It's how you do multithreading in OGL.
kd-11
reviewed
Jan 25, 2025
| } | ||
|
|
||
| void gl_gs_frame::delete_context(draw_context_t ctx) | ||
| { | ||
| const auto gl_ctx = static_cast<GLContext*>(ctx); | ||
|
|
||
| gl_ctx->handle->doneCurrent(); | ||
| // Calling this on the main thread is necessery in debug builds. |
There was a problem hiding this comment.
Same here, cannot be done from main thread. Anything with "current" is thread-local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code causes exceptions in debug builds if not called from the main thread.