Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

determine and install dependencies with {pak} #97

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Feb 9, 2024

closes #96

@cjyetman cjyetman marked this pull request as ready for review February 9, 2024 01:06
@cjyetman
Copy link
Member Author

cjyetman commented Feb 9, 2024

This seems to work on my machine. Can either @jdhoffa and/or @AlexAxthelm verify that one their machines?

@jdhoffa
Copy link
Member

jdhoffa commented Feb 9, 2024

Same as #98 , I am not sure where I can find the relevant data prep input data to be able to test this locally.

@cjyetman
Copy link
Member Author

cjyetman commented Feb 9, 2024

Same as #98 , I am not sure where I can find the relevant data prep input data to be able to test this locally.

Maybe @AlexAxthelm is better suited to answer this because now all of the input files are stored on Azure, and there's two separate "rawdata" directories, and honestly I'm a bit confused myself what the structure is supposed to be and also find it rather difficult to navigate Azure to get to them. I used input files that I already had on my laptop.

@jdhoffa
Copy link
Member

jdhoffa commented Feb 9, 2024

Same as #98 , I am not sure where I can find the relevant data prep input data to be able to test this locally.

Maybe @AlexAxthelm is better suited to answer this because now all of the input files are stored on Azure, and there's two separate "rawdata" directories, and honestly I'm a bit confused myself what the structure is supposed to be and also find it rather difficult to navigate Azure to get to them. I used input files that I already had on my laptop.

Sounds good! Once that is resolved, I will review this :-)
(not trying to block things, just trying to be more prudent in general on our PROD repos)

Dockerfile Show resolved Hide resolved
jdhoffa
jdhoffa previously approved these changes Feb 9, 2024
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built Docker image and everything installs as expected.
LGTM

@cjyetman cjyetman merged commit 44758b9 into main Feb 9, 2024
@cjyetman cjyetman deleted the install-with-pak-only branch February 9, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package install in Dockerfile fails because it cannot find package "R"
2 participants