update FactSet database connect info #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
it looks good to me, but I would defer to @AlexAxthelm for that one
mostly due to this ticket: https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/8919?src=WorkItemMention&src-action=artifact_link
AlexAxthelm
approved these changes
Dec 13, 2023
|
Note this is intended to be a short-lived database, and will probably not be available for next round of data prep. I am preparing a PR that will work for a long-term solution. |
|
closing then... makes sense to wait for the proper details |
|
Deleting branch, since all of the relevent work has migrated to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really know how/when/why these connect details changed, so would be good if @AlexAxthelm and/or @Antoine-Lalechere can validate these changes.