Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose is now docker compose #242

Merged
merged 1 commit into from
Jul 22, 2024
Merged

docker-compose is now docker compose #242

merged 1 commit into from
Jul 22, 2024

Conversation

cjyetman
Copy link
Member

No description provided.

@cjyetman cjyetman requested review from AlexAxthelm and jdhoffa July 22, 2024 11:00
Copy link

Docker build status

commit_time git_sha image
2024-07-22T11:00:23Z e45e691 ghcr.io/rmi-pacta/workflow.data.preparation:pr-242

Copy link
Collaborator

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: Everything works for these commands (which are the most common), but last I checked, docker-compose and docker compose are not fully interchangeable, and there were some differing behaviors in the commands (usually the less-used ones).

I might be (hope I am) wrong, but just something to be aware of.

cc @jdhoffa

@cjyetman
Copy link
Member Author

@cjyetman cjyetman merged commit 4ed6583 into main Jul 22, 2024
6 checks passed
@cjyetman cjyetman deleted the cjyetman-patch-1 branch July 22, 2024 17:10
@jdhoffa
Copy link
Member

jdhoffa commented Jul 23, 2024

Yeah I've found docker compose to be a pretty huge pain in the butt in the past, and always default to using docker-compose still.

But if it's your decision to start using this new cli and you want to deal with whatever issues that may introduce, then happy with that!

@cjyetman
Copy link
Member Author

I get errors when I use docker-compose, so docker compose is the only way that currently works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants