-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update 23Q4 scenario timestamp for desktop config #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to keep in sync with #236
Docker build status
|
jdhoffa
approved these changes
Jun 28, 2024
jdhoffa
added a commit
that referenced
this pull request
Jul 1, 2024
The initial scenario preparation configuration bump that was committed in #236 and #237 pointed to a scenario preparation output that was missing crucial data. The data was missing due to a bug that was introduced in: RMI-PACTA/pacta.scenario.data.preparation#61 and later solved by: RMI-PACTA/pacta.scenario.data.preparation#63 The new scenario preparation outputs, in the directory: `2023Q4_20240701_T105302Z` which can be found here: https://pactadatadev.file.core.windows.net/workflow-scenario-preparation-outputs/2023Q4_20240701_T105302Z contain all the expected output datasets.
jdhoffa
added a commit
that referenced
this pull request
Jul 1, 2024
The initial scenario preparation configuration bump that was committed in #236 and #237 pointed to a scenario preparation output that was missing crucial data. The data was missing due to a bug that was introduced in: RMI-PACTA/pacta.scenario.data.preparation#61 and later solved by: RMI-PACTA/pacta.scenario.data.preparation#63 The new scenario preparation outputs, in the directory: `2023Q4_20240701_T105302Z` which can be found here: https://pactadatadev.file.core.windows.net/workflow-scenario-preparation-outputs/2023Q4_20240701_T105302Z contain all the expected output datasets.
jdhoffa
added a commit
to RMI-PACTA/workflow.transition.monitor
that referenced
this pull request
Jul 1, 2024
The newly created data directory now contains APS and STEPS scenarios for WEO 2023 for the aviation, cement and steel sectors. With these scenarios missing, the executive summary couldn't render correctly. Relates to: RMI-PACTA/workflow.data.preparation/pull/238 RMI-PACTA/workflow.data.preparation/pull/237 RMI-PACTA/workflow.data.preparation/pull/236 RMI-PACTA/pacta.scenario.data.preparation/pull/61 RMI-PACTA/pacta.scenario.data.preparation/pull/63
jdhoffa
added a commit
to RMI-PACTA/workflow.transition.monitor
that referenced
this pull request
Jul 18, 2024
The newly created data directory now contains APS and STEPS scenarios for WEO 2023 for the aviation, cement and steel sectors. Importantly also, we had to update paths to the new (real) `peer` files, as those had to be re-run with those same latest scenarios. With these scenarios missing, the executive summary couldn't render correctly. Relates to: RMI-PACTA/workflow.data.preparation/pull/238 RMI-PACTA/workflow.data.preparation/pull/237 RMI-PACTA/workflow.data.preparation/pull/236 RMI-PACTA/pacta.scenario.data.preparation/pull/61 RMI-PACTA/pacta.scenario.data.preparation/pull/63 --------- Co-authored-by: Alex Axthelm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to keep in sync with #236