-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: use FactSet data pulled in April #225
Conversation
includes new ISINs for PA2024CH project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks. @jdhoffa is going to check with all relevant people to make sure they understand the consequences of changing the data midstream in a COP project, and I will approve/merge once I get a positive feedback from that. |
ack, sorry... for 2023Q4 this is fine to do now |
I think this is still relevant, since this change is specifically intended to resolve issues with PA2024CH. |
actually, I think we should consider this more... I think it might be prudent to create a new |
@Antoine-Lalechere and @AlexAxthelm thanks for this! |
CJ, to this end I have created a new issue here: #226 Given that GENERAL has not yet been released, and we have no other COP projects, I am tempted to deprioritize this for now, but I think this feature will be something we should tackle if ever we intend to do another COP project this year (e.g. using 2023Q4 data) |
Based on this decision: https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/10208#30766213 We are good to go! @AlexAxthelm feel free to merge when ready. |
Includes new ISINs, as well as update Fund data as requested from a CH user, for the PA2024CH project.