Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy only needed files to /workflow.data.preparation/ in Docker image #175

Merged
merged 1 commit into from
Feb 26, 2024
Merged

copy only needed files to /workflow.data.preparation/ in Docker image #175

merged 1 commit into from
Feb 26, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Feb 26, 2024 •
edited
Loading

closes #173
closes #172

  • moves WORKDIR /workflow.data.preparation up so we don't have to keep specifying it
  • copies .env and DESCRIPTION simultaneously
  • copies .git/ separately because I can't figure out if/how to do a multi-copy including a sub-directory
  • copies config.yml run_pacta_data_preparation.R simultaneously

should we also remove the explicit .dockerignore @AlexAxthelm?

AlexAxthelm
AlexAxthelm approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@AlexAxthelm AlexAxthelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally prefer specifying the absolute paths in COPY, but this works fine.

@cjyetman cjyetman merged commit bd6b996 into main Feb 26, 2024
2 checks passed
@cjyetman cjyetman deleted the copy-only-needed-files branch February 26, 2024 20:49
@cjyetman cjyetman mentioned this pull request Feb 27, 2024
Closed
@cjyetman cjyetman linked an issue Feb 27, 2024 that may be closed by this pull request
Don't write to file system root in docker image #172
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAxthelm AlexAxthelm AlexAxthelm approved these changes

@jdhoffa jdhoffa Awaiting requested review from jdhoffa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicitly COPY only needed files in Docker build Don't write to file system root in docker image
2 participants
@cjyetman @AlexAxthelm