-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default 2023Q4 config #136
Conversation
may additionally require something like... @AlexAxthelm? 2023Q4_azure:
inherits: 2023Q4
data_prep_outputs_path: "/mnt/outputs"
asset_impact_data_path: "/mnt/asset-impact"
factset_data_path: "/mnt/factset-extracted/factset-pacta_timestamp-20231231T000000Z_pulled-20240217T135833Z"
masterdata_ownership_filename: "2024-02-15_AI_RMI_2023Q4/2024-02-14_AI_RMI Bespoke_Company Data Products_masterdata_ownership_2023Q4.csv"
masterdata_debt_filename: "2024-02-15_AI_RMI_2023Q4/2024-02-14_AI_RMI Bespoke_Company Data Products_masterdata_debt_2023Q4.csv"
ar_company_id__factset_entity_id_filename: "2024-02-15_AI_RMI_2023Q4/2024-02-14_AI_RMI_Bespoke_Company_Data_Products_Company_ID_List_2023Q4.csv" |
Add config matching format in #145
add filepaths to latest known working input data files Closes: 144
zero_emission_factor_techs: ["Electric", "HydroCap", "NuclearCap", "RenewablesCap"] | ||
green_techs: ["FuelCell", "Electric", "Hybrid", "RenewablesCap", "HydroCap", "NuclearCap", "FuelCell_HDV", "Electric_HDV", "Hybrid_HDV"] | ||
scenario_raw_data_to_include: ["geco_2023", "isf_2023", "weo_2023"] | ||
tech_exclude: ["OtherCap", "OtherFF", "Coking Plant", "Sintering Plant", "Direct Or Smelting Reduction Plant", "Pelletizing Plant", "Grinding Plant", "Passenger / Freight"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
none of these exist directly in the raw AI data for 2023
"Passenger" and "Freight" do exist separately in the raw AI data for 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is the right person to tag for input on this? @Antoine-Lalechere @NickPACTA ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we/I have to dig into the code and really clearly wrap my head around where/how they're being used, and verify if they exist anywhere in the data that might hit that code. If not, then I think it would be best to remove these (from the 2023Q4 config anyway).
On the other side, it might be prudent to review the relevant list of technologies that do exist in 20223Q4 and consider if any of them should be added here. For that, I'm honestly unsure who would/should make that decision. Maybe Nick?
opening for review/merge. #176 will track updating the parameters once they've been fully investigated/validated @AlexAxthelm |
I've been using this config as-is for the past few DEV data preps. I'm comfortable with these setting resulting in a valid dataset. @Antoine-Lalechere has reviewed outputs for 2023Q4, and they are largely consistent with the 2022Q4 outputs. |
closes #144