Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test-Docker-build-works.yml #115

Merged
merged 18 commits into from
Apr 17, 2024
Merged

Create test-Docker-build-works.yml #115

merged 18 commits into from
Apr 17, 2024

Conversation

cjyetman
Copy link
Member

@cjyetman cjyetman commented Feb 9, 2024

adds a very quick and simple test to ensure that a successful build of the Docker image is not affected by a PR

@AlexAxthelm
Copy link
Collaborator

@cjyetman We're getting close to including docker actions in https://github.com/RMI-PACTA/actions. Maybe let's just use that? (some time next week)

@cjyetman
Copy link
Member Author

cjyetman commented Feb 9, 2024

@cjyetman We're getting close to including docker actions in https://github.com/RMI-PACTA/actions. Maybe let's just use that? (some time next week)

trying to achieve something completely different than that here

@cjyetman cjyetman marked this pull request as draft February 10, 2024 05:50
@AlexAxthelm
Copy link
Collaborator

@cjyetman what are you trying to achieve with this PR? Under the current system, the docker build process requires a .env file with a GH PAT that has read access to some private repos, which isn't being added here.

Possible options:

  • Use docker build secrets
  • Add a step to write a .env file that has the REPO_PAT GH Actions secret
  • wait until there aren't dependencies on private repos.

@cjyetman
Copy link
Member Author

I wanted a quick auto-test that the Docker build does not get broken by changes... because otherwise I'm testing locally once in RStudio and then once in Docker every time I change something.

@cjyetman
Copy link
Member Author

Yeah, I stalled on enabling the GitHub PAT and figured it would be easier to just wait till we're not using private repos anymore, e.g. the requisite repos become public.

@cjyetman cjyetman marked this pull request as ready for review April 17, 2024 10:30
@cjyetman cjyetman requested a review from jdhoffa April 17, 2024 10:31
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cjyetman cjyetman merged commit b4f6273 into main Apr 17, 2024
1 check passed
@cjyetman cjyetman deleted the cjyetman-patch-1 branch April 17, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants