Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

determine a better way to share secrets with the container #3

Closed
cjyetman opened this issue Mar 21, 2023 · 2 comments
Closed

determine a better way to share secrets with the container #3

cjyetman opened this issue Mar 21, 2023 · 2 comments
Labels
Docker

Comments

@cjyetman
Copy link
Member

Currently, the .env file with secrets (which a user needs to create locally) is copied into the Docker image (along with everything else). The GitHub PAT is necessary so the pkg install commands in the Dockerfile can install our private packages. The database credentials are needed during runtime in an instance so that it can connect to our FactSet data.

Although we have no intention of sharing a Docker image created with this repo with anyone, it would be ideal to find a way to not burn these secrets into the image.
@cjyetman
Copy link
Member Author

Some thoughts about this were discussed here RMI-PACTA/pacta.data.preparation#13

This was referenced Jan 18, 2024
Closed
Closed
@cjyetman cjyetman mentioned this issue Feb 9, 2024
Closed
5 tasks
@cjyetman
Copy link
Member Author

cjyetman commented Mar 7, 2024

closing in favor of #102

@cjyetman cjyetman closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/azure container RMI-PACTA/workflow.data.preparation
1 participant
@cjyetman