remove GITHUB_PAT requirement

[cjyetman]

• depends on https://github.com/RMI-PACTA/pacta.scenario.preparation/issues/123
• depends on https://github.com/RMI-PACTA/pacta.data.preparation/issues/283
• depends on Migrate existing preparation scripts for 2022Q4 scenarios workflow.scenario.preparation#10
• depends on Add preparation scripts for 2023Q4 scenarios workflow.scenario.preparation#9
• depends on Migrate prepare_X_YYYY_scenario() functions out of main.R pacta.scenario.data.preparation#12

Currently a GITHUB_PAT environment variable is required for the Docker context in order to install RMI-PACTA/pacta.scenario.preparation and RMI-PACTA/pacta.data.preparation. If both of those packages ever become public, it would be advantageous to remove that requirement.

changes would be needed here:

workflow.data.preparation/README.md

Line 39 in c08b8fb

GITHUB_PAT=ghp_XXXXxxXxXXXxXxxX

workflow.data.preparation/README.md

Lines 49 to 51 in c08b8fb

	- `GITHUB_PAT` valid GitHub PAT that grants access to the repos:
	- [RMI-PACTA/pacta.scenario.preparation](https://github.com/RMI-PACTA/pacta.scenario.preparation)
	- [RMI-PACTA/pacta.data.preparation](https://github.com/RMI-PACTA/pacta.data.preparation)

AB#10386

[jdhoffa]

Relates to RMI-PACTA/pacta.scenario.data.preparation#2

[cjyetman]

I guess this would not be needed anymore too, because in this context it's only used to make GITHUB_PAT available for the R pkgs install. @jdhoffa do you agree?

workflow.data.preparation/Dockerfile

Line 20 in c08b8fb

readRenviron(".env"); \

[AlexAxthelm]

FYI: consider using build secrets (https://docs.docker.com/build/building/secrets/), as is happening in the ACI dockerfile

workflow.data.preparation/ACI/Dockerfile.ACI

Lines 39 to 49 in acc9c0f

	# install pak, find dependencises from DESCRIPTION, and install them.
	RUN --mount=type=secret,id=github_pat \
	Rscript -e "\
	Sys.setenv(GITHUB_PAT = readLines('/run/secrets/github_pat')); \
	install.packages('pak'); \
	deps <- pak::local_deps(root = '.'); \
	pkg_deps <- deps[!deps[['direct']], 'ref']; \
	cat(pkg_deps); \
	pak::pak(pkg_deps); \
	Sys.unsetenv('GITHUB_PAT'); \
	"

[cjyetman]

also relates to RMI-PACTA/archive.pacta.data.preparation#3

[jdhoffa]

Comment updated with additional context relating to:

https://github.com/RMI-PACTA/workflow.scenario.preparation
and
https://github.com/RMI-PACTA/pacta.scenario.data.preparation

[AlexAxthelm]

@cjyetman @jdhoffa I think this was closed with #217, no?

I was able to build and start the Data prep docker image without a GH PAT.

[cjyetman]

yup, thanks.... closing