Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calls to write_manifest() #147

Closed
AlexAxthelm opened this issue Feb 18, 2024 · 0 comments · Fixed by #149
Closed

Update calls to write_manifest() #147

AlexAxthelm opened this issue Feb 18, 2024 · 0 comments · Fixed by #149

Comments

@AlexAxthelm
Copy link
Collaborator

Update calls to write_manifest() to account for https://github.com/RMI-PACTA/pacta.data.preparation/issues/340
@AlexAxthelm AlexAxthelm mentioned this issue Feb 18, 2024
Closed
AlexAxthelm added a commit that referenced this issue Feb 18, 2024
@AlexAxthelm
feat(package): #147 Update dependency
2f63203 
update required version of `pacta.data.preparation`
AlexAxthelm added a commit that referenced this issue Feb 18, 2024
@AlexAxthelm
feat(app): #147 convert checks to use input_filepaths
2866159 
Create an input_filepaths object, rather than use individual filepaths
AlexAxthelm added a commit that referenced this issue Feb 18, 2024
@AlexAxthelm
fix(app): #147 Move data prep outputs path out of input files
e9f5e18 
Closes: #147
AlexAxthelm added a commit that referenced this issue Feb 18, 2024
@AlexAxthelm
feat(app): #147 Use input_filepaths in parameters
32b7c23
@AlexAxthelm AlexAxthelm mentioned this issue Feb 18, 2024
Merged
2 tasks
AlexAxthelm added a commit that referenced this issue Feb 18, 2024
@AlexAxthelm
refactor(app): #147 Move code to avoid conflict
35fd720
AlexAxthelm added a commit that referenced this issue Feb 18, 2024
@AlexAxthelm
feat(app): #147 INclude preflight paths in input_filepaths
15058c5 
adjust code to account for changes made in #150
AlexAxthelm added a commit that referenced this issue Feb 18, 2024
@AlexAxthelm
feat(app): #147 Use explicit filepaths for archives
4239eae 
Use explicit filepath vectors for archive export process defined in #153
AlexAxthelm added a commit that referenced this issue Feb 23, 2024
@AlexAxthelm
feat(app): #147 remove unused code block
db364f0 
Removed block of code that would check for existence of a directory that
is created earlier in script.
AlexAxthelm added a commit that referenced this issue Feb 23, 2024
@AlexAxthelm
feat(app): #147 Use output_files in archive step
2b233a4 
Use the `output_files` list of filepaths for archive step.
AlexAxthelm added a commit that referenced this issue Feb 23, 2024
@AlexAxthelm @cjyetman
Feat/147 update calls to write manifest (#149)
a4b662b 
Update run_data_preparation to use changed function in
https://github.com/RMI-PACTA/pacta.data.preparation/pull/341.

Also simplifies somewhat the logic around the list of input filepaths.

Should be merged after that, but coordinated closely.

**Note:** as-written, this includes #150, but reverting back to
[35fd720](35fd720)
removes that dependency.

Also as written, depends on #153, as this does a similar simplification
from `list.files()` to explicit filepath lists for the archive export
feature defined in that PR. Reverting
[1b8cd49](1b8cd49)
removes that connection.

- [x] Depends on #150 
- [x] Depends on #153 

Closes #147

---------

Co-authored-by: CJ Yetman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/147 update calls to write manifest RMI-PACTA/workflow.data.preparation
1 participant
@AlexAxthelm