Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checks #508

Merged
merged 3 commits into from
May 12, 2023
Merged

Fix checks #508

merged 3 commits into from
May 12, 2023

Conversation

MonikaFu
Copy link
Collaborator

@MonikaFu MonikaFu commented May 12, 2023 •
edited
Loading

Closes #500
Closes #507

Update code so checks are passing.

@MonikaFu MonikaFu marked this pull request as draft May 12, 2023 12:21
@MonikaFu MonikaFu marked this pull request as ready for review May 12, 2023 12:39
@MonikaFu MonikaFu requested a review from jdhoffa May 12, 2023 12:40
@MonikaFu MonikaFu self-assigned this May 12, 2023
jdhoffa
jdhoffa reviewed May 12, 2023
View reviewed changes
R/utils.R Show resolved Hide resolved
jdhoffa
jdhoffa approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay LGTM

@jdhoffa jdhoffa merged commit 8fcd90e into main May 12, 2023
@jdhoffa jdhoffa deleted the fix_checks branch May 12, 2023 14:56
@cjyetman cjyetman mentioned this pull request May 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman cjyetman left review comments

Assignees

@MonikaFu MonikaFu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and handle failing tests @jdhoffa yes, sounds good to me. Will you make an issue for it?
3 participants
@MonikaFu @cjyetman @jdhoffa