Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export to_alias #158

Closed
wants to merge 1 commit into from
Closed

Export to_alias #158

wants to merge 1 commit into from

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Mar 2, 2020

Closes #157

@maurolepore
Copy link
Contributor

maurolepore commented Mar 2, 2020

Thanks @jdhoffa and @vintented. It's great to see that the package is useful and you want more features.

@jdhoffa,

Would exporting to_alias() solve @vintented's need? Or is he asking for match_name() to gain the argument remove_ownership?

@jdhoffa
Copy link
Member Author

jdhoffa commented Mar 2, 2020

@maurolepore I think both are actually desirable.
For his purposes, the flexibility of connecting a call to to_alias to a call to score_alias_similarity is enough I think.

That said, we need to be careful and remember that the number 1 purpose of match_name is still the banks work (at this stage anyway)

@jdhoffa
Copy link
Member Author

jdhoffa commented Mar 2, 2020

(So we should be careful to not make match_name to general. We want to have a very simple workflow for the banks work. Once that is achieved we can begin to export underlying functions for use by our analysts.)
Remember this is the conversation we had a long while ago, when Klaus and I disagreed. Me saying that more flexibility is desirable for 2DII analysts, him saying that more clear wrappers and simplicty is desirable for the banks. I think finding this balance might be tricky.

R/to_alias.R Show resolved Hide resolved
R/to_alias.R Show resolved Hide resolved
R/to_alias.R Show resolved Hide resolved
@maurolepore
Copy link
Contributor

maurolepore commented Mar 2, 2020

For his purposes, the flexibility of connecting a call to to_alias to a call to score_alias_similarity is enough I think.

Does this mean we need to also export score_alias_similarity()? Or for now should we encourage users of to_alias() to score similarity themselves directly with stringsim::stringdist() (in this case they would also need to handle sector themselves)?

@jdhoffa jdhoffa closed this Mar 2, 2020
@jdhoffa jdhoffa deleted the 157-export-to_alias branch May 18, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: match_name gains additional company legal structure abbreviation alias
2 participants