Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete deprecation of ald_demo and green_or_brown #333

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Feb 7, 2024

These datasets were flagged as "ready for deprecation" a few releases ago, so technically we are a bit behind on this, but not a big deal.

Closes #307 and #329

@jdhoffa jdhoffa added breaking change ☠️ API change likely to affect existing code upkeep maintenance, infrastructure, and similar labels Feb 7, 2024
@jdhoffa jdhoffa requested a review from AlexAxthelm February 7, 2024 16:40
@jdhoffa jdhoffa self-assigned this Feb 7, 2024
@jdhoffa jdhoffa requested a review from cjyetman February 7, 2024 17:02
@cjyetman
Copy link
Member

cjyetman commented Feb 7, 2024

looks like there are merge conflicts that need to be resolved first?

@jdhoffa
Copy link
Member Author

jdhoffa commented Feb 7, 2024

True! Should be solved.

@jdhoffa jdhoffa merged commit 36e34d6 into main Feb 8, 2024
24 checks passed
@jdhoffa jdhoffa deleted the 328-complete_ald_deprecation branch February 8, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete green_or_brown to increasing_or_decreasing deprecation process
3 participants