Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin deprecation of isic_classification and cnb_classification #331

Merged
merged 14 commits into from
Feb 12, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Feb 7, 2024

See discussion in #327 where this decision was made.

Begins to address #329

@jdhoffa jdhoffa added feature a feature request or enhancement breaking change ☠️ API change likely to affect existing code labels Feb 7, 2024
@jdhoffa jdhoffa self-assigned this Feb 7, 2024
@jdhoffa jdhoffa requested a review from jacobvjk February 7, 2024 16:09
@jdhoffa jdhoffa requested a review from AlexAxthelm February 8, 2024 14:09
jacobvjk
jacobvjk previously approved these changes Feb 12, 2024
Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jacobvjk jacobvjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdhoffa jdhoffa merged commit 835d953 into main Feb 12, 2024
24 checks passed
@jdhoffa jdhoffa deleted the 329-deprecate_classification_datasets branch February 12, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code feature a feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants