Replace TODOs with issues #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #213
test-calculate_company_alignment_metric.R:# TODO: add expectations for the actual output valuesis removed as outdated as the calculation has already gained expected output values below# TODO: add a case of a pure phaseout sectorgains follow up GH issue Add pure phase out test case forcalculate_company_aggregate_alignment_tms()#283NAcases related totest-calculate_company_alignment_metric.R#282 is created for the three instances of# TODO: reconsider if this needs to be handled somewhere else, effectively NAs are treated like zerovignettes/cookbook_running_the_analysis.Rmd,<!---TODO: maybe some of the project_parameters should be in the config section analysis, if thei are not used in other parts of the workflow--->is removed, because the parameters in theproject_parameterssection of the config have impacts across steps of the workflow, which makes the suggested idea impractical