Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider NA cases related to test-calculate_company_alignment_metric.R #282

Open
jacobvjk opened this issue Dec 2, 2024 · 0 comments
Open

Reconsider NA cases related to test-calculate_company_alignment_metric.R #282

jacobvjk opened this issue Dec 2, 2024 · 0 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@jacobvjk
Copy link
Member

jacobvjk commented Dec 2, 2024 •
edited
Loading

Relates to #213

There are a number of test cases that currently show NAs are treated the same as 0 values when removing inactive companies. Reconsider if these should be removed elsewhere and tests adjusted accordingly.

See:
@jacobvjk jacobvjk added the upkeep maintenance, infrastructure, and similar label Dec 2, 2024
@jacobvjk jacobvjk self-assigned this Dec 2, 2024
@jacobvjk jacobvjk mentioned this issue Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacobvjk