Move npm run build as part of docker build
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker build status
|
|
jdhoffa
requested changes
Dec 9, 2024
scripts/build.sh
Outdated
There was a problem hiding this comment.
I guess we should probably also rename this script, since it doesn't build at all anymore?
Since it's a single line, I would just remove the script altogether, and call the cp command in-line in the Dockerfile
There was a problem hiding this comment.
Makes sense. d509d03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
npm run buildin docker image to generate built dashboard files in docker image (making them available forCOPY --fromin other images)Closes #128
Supports RMI-PACTA/workflow.pacta.dashboard#33