Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Enum Fixes + Tweaks #100

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Various Enum Fixes + Tweaks #100

merged 2 commits into from
Jan 2, 2024

Conversation

gbdubs
Copy link
Contributor

@gbdubs gbdubs commented Jan 2, 2024

  • Adds an enum prefix for every OpenAPI enum type, to avoid collisions + clean up the namespace (otherwise constants like api.En are generated).
  • Removes use of YAML feature I hadn't understood prior (anchors + links), putting everything into the schemas, since definitions look like they're a Swagger (OAPI2.0) construct.
  • Adds some basic Enum Round-Trip unit tests to pactasrv/conv
  • removes usage of pacta.ParseX functions within the conv package, since these are less reliable than using the one for one, switch driven converters.

@gbdubs gbdubs requested a review from bcspragu January 2, 2024 17:47
cmd/server/pactasrv/conv/oapi_to_pacta.go Outdated Show resolved Hide resolved
@gbdubs gbdubs enabled auto-merge (squash) January 2, 2024 21:05
@gbdubs gbdubs merged commit 3ce34fc into main Jan 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants