Support on premise Active Directory #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you want me to update the |
|
Thanks for the feature! Is it possible to please add in a small test just to verify the behaviour works as expected (at least as far as the impact on the gem's behaviour when the relevant configuration is set)? Please do add an explanation of what the client code should configure for on-prem into an appropriate part of |
|
Great, thank you. I've added documentation and tests! |
|
This is now released as v2.3.0. |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure whether you want to support on premise Active Directory with this gem, but these changes allow the gem to be used for authentication against an on premise Active Directory system.