Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP notifications system #150

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Conversation

K-w-e
Copy link
Contributor

@K-w-e K-w-e commented Feb 6, 2024

Hi,
I have submitted a pull request, but it is not yet 100% complete, and I am seeking your guidance.
I've tested notifications on the emulator, and it works correctly. However, when building the app in release mode, I get the error "Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.7.0, expected version is 1.5.1.".

If you have any insights or suggestions on how to address this Kotlin version compatibility issue, it would be very appreciated.

Additionally, for context, I'm using the WorkerManager library to schedule notifications (it may be useful for scheduling recurring transactions as well).

@theperu theperu marked this pull request as draft February 7, 2024 17:54
@theperu
Copy link
Collaborator

theperu commented Feb 7, 2024

Hi! I marked this PR as a draft since it's not ready yet, unfortunately I don't know enough about notifications to help you out. Maybe @lucaantonelli as more knowledge about it

@mikev-cw
Copy link
Collaborator

mikev-cw commented Feb 8, 2024

Hi! I marked this PR as a draft since it's not ready yet, unfortunately I don't know enough about notifications to help you out. Maybe @lucaantonelli as more knowledge about it

Yeah, we definitely need him! 😆

@K-w-e
Copy link
Contributor Author

K-w-e commented Feb 9, 2024

PR updated with the latest changes, and it seems to be functioning correctly now.
I've tested it on android, but unfortunately, I can't perform additional testing on iOS devices.

Let me know if you have any suggestions!

@theperu
Copy link
Collaborator

theperu commented Feb 9, 2024

Great! Could you also explain a little bit how the notifications should work?

@K-w-e
Copy link
Contributor Author

K-w-e commented Feb 9, 2024

Sure!
Since we are not using an external tool like firebase to register each device and send him a notification through a backend service, i opted for local_flutter_notification to build notifications directly within the app. By utilizing Workmanager you can schedule it each 1/7/30 days (or whenever you want), and this is working also when the app is closed/in background.

For proper organization and customization, each "notification type" in the app should have its own channel to keep their settings separate.
image

Feel free to add or ask anything else

@K-w-e
Copy link
Contributor Author

K-w-e commented Feb 9, 2024

Let me add one more thing.
Through the Workmanager library, you can schedule all possible tasks, including recurring transactions. I don't know if you have already considered any other solutions.

@mikev-cw
Copy link
Collaborator

mikev-cw commented Feb 9, 2024

Let me add one more thing.

Through the Workmanager library, you can schedule all possible tasks, including recurring transactions. I don't know if you have already considered any other solutions.

Super! Yes, recurring transactions would works exactly like this.
I was working on that, let me deeply check your work on next days

@mikev-cw
Copy link
Collaborator

As seen on our Discord, seems that this doesn't work on iOS, due to system limitation.
For now we will leave this feature for Android users only, see #160
We just need to hide or disable this feature on iOS, then we can merge this

@K-w-e
Copy link
Contributor Author

K-w-e commented Mar 22, 2024

@mikev-cw
Would you like it to be disabled, similar to the "Import/Export" button, or simply remove the "Notifications" button from the menu on iOS?

@mikev-cw
Copy link
Collaborator

@mikev-cw Would you like it to be disabled, similar to the "Import/Export" button, or simply remove the "Notifications" button from the menu on iOS?

Just do what you think is the right thing! My personal opinion is that we should hide the option, since is not available in that specific platform, but you decide. :)

@K-w-e
Copy link
Contributor Author

K-w-e commented Mar 22, 2024

@mikev-cw Would you like it to be disabled, similar to the "Import/Export" button, or simply remove the "Notifications" button from the menu on iOS?

Just do what you think is the right thing! My personal opinion is that we should hide the option, since is not available in that specific platform, but you decide. :)

Ok basically in the last commit i'm hiding the options without actions on click

@mikev-cw mikev-cw marked this pull request as ready for review March 25, 2024 21:48
@mikev-cw mikev-cw linked an issue Mar 25, 2024 that may be closed by this pull request
@mikev-cw mikev-cw merged commit 5f30d1a into RIP-Comm:main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification system
3 participants