Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock-sync-task #305

Merged
merged 2 commits into from
Oct 31, 2024
Merged

lock-sync-task #305

merged 2 commits into from
Oct 31, 2024

Conversation

dcritch
Copy link
Contributor

@dcritch dcritch commented Oct 31, 2024

  • move the portal jira sync function to libtelco5g
  • add lock logic around it

@dcritch dcritch requested a review from adhil0 October 31, 2024 17:35
Copy link
Collaborator

@adhil0 adhil0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@@ -190,6 +190,8 @@ def set_cfg():
cfg["sla_settings"] = json.loads(os.environ.get("sla_settings"))
# sso
cfg["rbac"] = os.environ.get("rbac").split(",") if os.environ.get("rbac") else []
cfg["max_to_create"] = os.environ.get("max_to_create")
cfg["alert_email"] = os.environ.get("alert_email")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alert_email is set to cfg['alert_to'] above, maybe we should unify these two

@adhil0 adhil0 merged commit 5aa6536 into main Oct 31, 2024
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants