Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing the load_data function from multiple places #279

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

npalchur
Copy link
Contributor

Rework load_data() in ui.py #273

In ui.py, we have a function called load_data() that we are using to gather data for the various UI views , removing that function from multiple places

@npalchur npalchur changed the title removing the load_data function multiple removing the load_data function from multiple places Mar 27, 2024
Copy link
Contributor

@dcritch dcritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I'll load it up in my environment later to test, but looking good! just a minor suggestion.

this should definitely speed things up!

dashboard/src/t5gweb/ui.py Show resolved Hide resolved
dashboard/src/t5gweb/ui.py Show resolved Hide resolved
@dcritch
Copy link
Contributor

dcritch commented Mar 27, 2024

couple more linter errors, and you need a rebase

@adhil0 adhil0 merged commit 0a60479 into RHsyseng:main Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants