-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OGC Features queryables bugfix + cleaner curie generation #284
OGC Features queryables bugfix + cleaner curie generation #284
Conversation
recalcitrantsupplant
commented
Oct 17, 2024
- OGC Features bugfix for auto generated queryables.
- Add upfront validation of curie -> URI and raise URI not found exception if appropriate.
- Add special characters to those excluded from CURIE generation: "aeiou!@#$%^&*()_+-=,."
Add upfront validation of curie -> URI and raise URI not found exception if appropriate. Add special characters to those excluded from CURIE generation: "aeiou!@#$%^&*()_+-=,."
… profiles used to declare default profiles as prez:IndexProfiles. Fix count query bug. Improve performance of annotations retrieval.
Looks good, seems to work fine. However, I am still getting a parser issue in prez-ui, even Will add to the relevant issue thread. probably safer not to have any of those characters in the prefixes anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. looks good
Actually, looking at the turtle spec https://www.w3.org/TR/turtle/#grammar-production-PN_PREFIX
it is illegal for a prefix to start with [0-9], which is I think what is causing the issues that I am experiencing.
still investigating
might need to revise the prefix generation further
good catch, yes I think you're right. We'll probably end up with the ns[1-9] type auto generated prefixes from RDFLib in a lot of cases "2.0" -> "" -> ns1 etc. |
@recalcitrantsupplant , I have implemented the prefix fix. you'll see that i am hashing the uri to get a prefix. I wonder if we could also do this in place of 'ns1' 'ns2' style prefixes? did you say that was an rdflib thing? or is that something we can control from Prez? just thinking that it would stop the prefixes from changing. because you should always get the same prefix for the same URI |
eae19a3
to
72c2dc2
Compare
previous implementation allowed illegal prefixes to be generated, which would cause errors parsing the data with n3.js