Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only retrieve remote Prez profiles; count query bug; annotation performance #281

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

recalcitrantsupplant
Copy link
Collaborator

  1. Ensure only prez related profiles are loaded from remote stores by updating the profile selection query
  2. Type profiles used to declare default profiles as prez:IndexProfiles. This makes 1 easier
  3. Fix count query bug. Counts could previously be wrong in some instances - moved DISTINCT to correct place.
  4. Improve performance of annotations retrieval. Identified slow code and changed to a faster implementation.

… profiles used to declare default profiles as prez:IndexProfiles.

Fix count query bug.
Improve performance of annotations retrieval.
@recalcitrantsupplant
Copy link
Collaborator Author

@avillar I can't add you as a reviewer in this repo, will see if we can add you - but do let me know if this works OK for you

Copy link
Collaborator

@lalewis1 lalewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, counts are returning correctly now.

@lalewis1 lalewis1 merged commit 05645d5 into main Oct 17, 2024
2 checks passed
@lalewis1 lalewis1 deleted the david/startup-profiles-selection branch October 17, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants