Add binary format version 1 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the position of the byte size of the block, so that clients could potentially avoid instantiating `bitcoin::Block` and use the serialized block as `Vec<u8>` instead.
RCasatta
force-pushed
the
version_error
branch
from
bfde06f to
c39d5e3
Compare
the major bump is because the binary format changed, the new version can read the old serialization format but if the old version program try to read a new serialization format it will error on version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the position of the byte size of the block, so that clients could
potentially avoid instantiating
bitcoin::Blockand use the serialized blockas
Vec<u8>instead.