-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helm charts for Sentry configuration #311
base: main
Are you sure you want to change the base?
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
c520c7a
to
2dcd892
Compare
*/}} | ||
{{- define "app-config.sentryName" -}} | ||
{{- if .Values.sentry.service.name }} | ||
{{- printf "%s" .Values.sentry.service.name -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why these should be configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two don't need to be configurable, I made it that way just to give more flexibility in how the service names are displayed in Sentry as an extra option. I can remove that, if this is problematic or just not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not problematic and in general it's good to have the flexibility. However this adds a bit of complexity to the charts and since I haven't used the Sentry interface I don't know how much benefit this brings. You can decide on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for clarification, I removed the conditional values for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think in this case we can use existing chart variables such as {{ include "catalog-server.name" . }}
, {{ include "catalog-server.chart" . }}
, {{ .Release.Name }}
, {{ .Release.Service }}
instead of creating new functions in _helpers.tpl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvannierop, before I change something here, could you double-check if this is what you had in mind for those 2 variables (sentryName, sentryRelease), or you think it is better to use a different combination of variables for sentryName, e.g. instead of the fullName defined above, fix it to some string containing .Chart.Name .Chart.Version or .Release.Name
2dcd892
to
7562af7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work! One small thing is that would it be more efficient to replace package definitions like:
packages: "org.radarbase.oura,org.radarbase.connect"
to more simple
packages: "org.radarbase"
? So to basically trace from org.radarbase.*
?
# -- Set to true, if stack trace should be enabled | ||
enabled: true | ||
# -- Comma-separated list of package prefixes to be included in the stacktrace | ||
packages: "org.radarbase.appconfig,org.radarbase.lang,comparisons" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this package string correct? The comparisons
part looks strange to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,this is the one that is packaged under comparisons:
radar-expression-lang/src/main/kotlin/comparisons/Library.kt
If not needed, I can remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ewelinagr Did you perhaps miss this comment?
Yes, it could be simplified to |
Implements RB-152
Some of the components have been enhanced with Sentry monitoring. This PR: