Do not include jmx pods when monitoring is disabled #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please also make the jmx container to the second container in the pod so when running commands like |
pvannierop
force-pushed
the
feature/disable-metrics
branch
from
49c5aad to
aa71fc6
Compare
pvannierop
force-pushed
the
feature/disable-metrics
branch
from
aa71fc6 to
aa2f724
Compare
|
@keyvaann Added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Although the charts allow for disabling service monitoring, monitoring-related resources were created for radar-gateway and radar-push-endpoint. This would claim unneccessary resources on local test and development deploymen.
Solution
This PR removes Kubernetes assets from radar-gateway and radar-push-endpoint when monitoring is disabled.