Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ingress proxy-body-size when upload enabled in appserver #286

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

pvannierop
Copy link
Collaborator

Config option nginx.ingress.kubernetes.io/proxy-body-size was missing from the ingess to enable upload of large files.

@pvannierop pvannierop requested a review from keyvaann October 22, 2024 12:20
@pvannierop pvannierop self-assigned this Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@@ -18,6 +18,9 @@ metadata:
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
{{- if .Values.upload.enabled }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just add it for the annotation configuration instead of creating a new value and condition?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean that it is always present? I reasoned that when not needed it would be more secure to not add it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's huge security risk to have it always enabled. It will make it easier to do DoS attacks but I won't consider that something that we'd need to worry about.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will remove the conditional inclusion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pvannierop pvannierop force-pushed the feature/appserver-ingress-annotation-upload branch from 77fb8fe to 8a293b1 Compare October 22, 2024 14:17
@pvannierop pvannierop requested a review from keyvaann October 22, 2024 14:37
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit d652138 into main Oct 22, 2024
5 checks passed
@keyvaann keyvaann deleted the feature/appserver-ingress-annotation-upload branch October 22, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants