Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Spring Boot mail autoconfiguration when not sending notifications via email #502

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

pvannierop
Copy link
Contributor

Problem

When notifications via email is disabled in the config, the spring boot autoconfig would still validate the mail server credentials. This causes non-applicable mail server related errors when the email server was not correctly configured.

Solution

This PR will disable the Spring Boot mail autoconfiguration when sending email notifications is disabled.

@pvannierop pvannierop self-assigned this Oct 4, 2024
Copy link
Member

@mpgxvii mpgxvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pvannierop pvannierop merged commit cf251a1 into dev Oct 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants