[bugfix] Escape project name in MP request #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvannierop
requested review from
nivemaham,
Bdegraaf1234,
peyman-mohtashami and
yatharthranjan
as code owners
Prject name may contain spaces and strange characters.
pvannierop
force-pushed
the
bugfix/escape-url
branch
from
961b3a2
to
cdc2684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Rest source backend has an error when a project name contains a space. This is caused by the management-portal client not encoding the URL before making the request.
Solution
This PR will add escape of the URL for the api/projects/$projectId/subjects endpoint.