Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize Gradle build scripts #960

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Modernize Gradle build scripts #960

wants to merge 1 commit into from

Conversation

pvannierop
Copy link
Collaborator

@pvannierop pvannierop commented Sep 27, 2024 •
edited
Loading

Description:

This PR will update the Gradle build scripts to current best practices.

Included changes

Checklist:

  • The Main workflow has succeeded
  • The Gatling tests have passed
  • I have logged into the portal running locally with default admin credentials
  • I have updated the README files if this change requires documentation update
  • I have commented my code, particularly in hard-to-understand areas

@pvannierop pvannierop self-assigned this Sep 27, 2024
@pvannierop pvannierop force-pushed the refactor/modernize-gradle-build branch 6 times, most recently from f286c17 to 9715147 Compare September 29, 2024 12:36
@pvannierop
Modernize gradle build scripts
481bb85 
Includes:
- Translate Groovy DSL to Kotlin DSL
- Implement 'convention plugin' (see https://docs.gradle.org/current/userguide/sharing_build_logic_between_subprojects.html#sec:convention_plugins_vs_cross_configuration)
- Implement version catalog
- Upgrade to gradle 8.7
- Implement ktlint and correct code format problems
- Translate remaining Java files into Kotlin
@pvannierop pvannierop force-pushed the refactor/modernize-gradle-build branch from 9715147 to 481bb85 Compare September 29, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpgxvii mpgxvii Awaiting requested review from mpgxvii mpgxvii is a code owner

@nivemaham nivemaham Awaiting requested review from nivemaham nivemaham is a code owner

@yatharthranjan yatharthranjan Awaiting requested review from yatharthranjan yatharthranjan is a code owner

@Bdegraaf1234 Bdegraaf1234 Awaiting requested review from Bdegraaf1234 Bdegraaf1234 is a code owner

@peyman-mohtashami peyman-mohtashami Awaiting requested review from peyman-mohtashami peyman-mohtashami is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pvannierop pvannierop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pvannierop