Feature/subject pair dialog component expansion #710
Conversation
…cking successful build on windows
…o fix error caused by node update. see https://stackoverflow.com/a/69699772
…ubject.csv file
…ely not the most clean way to do this, at it was done by altering the changelogs, which negates their purpose to some extent.
| @@ -21,7 +21,7 @@ | |||
| --> | |||
| <changeSet id="20210929120000-1" author="[email protected]"> | |||
| <addColumn tableName="subject"> | |||
| <column name="date_of_birth" type="date"/> | |||
| <column name="date_of_birth" type="date" defaultValueDate="1999-01-01"/> | |||
There was a problem hiding this comment.
No changes should be made to existing Liquibase changeSets, because it leads to undefined state of the database. If you want to add a default value (I think we shouldn't, it should be null), a new changeset should be created.
There was a problem hiding this comment.
added a changeset with some testvalues in #713
There was a problem hiding this comment.
default value should still be removed -- it also affects production databases
| </addColumn> | ||
| </changeSet> | ||
| <changeSet id="20211006150000-2" author="[email protected]"> | ||
| <addColumn tableName="subject_aud"> | ||
| <column name="person_name" type="varchar(255)"/> | ||
| <column name="person_name" type="varchar(255)" defaultValue="John Doe"/> |
There was a problem hiding this comment.
Similar to above
No changes should be made to existing Liquibase changeSets, because it leads to undefined state of the database. If you want to add a default value (I think we shouldn't, it should be null), a new changeset should be created.
There was a problem hiding this comment.
added a changeset with some testvalues in #713
There was a problem hiding this comment.
This default value should still be removed. It also affects production databases.
|
Closed and moved to #713 |
Bdegraaf1234
deleted the
feature/subject-pair-dialog-component-expansion
branch
Description: Adds components to display the requested fields (name, date of birth, external id) in the subject-pair-dialogue
Fixes #706
Checklist: