Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Pass launch options via object #760

Merged
merged 8 commits into from
Feb 21, 2024

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Jan 19, 2024

Currently object only has a single member for bypassing all checks. In the future this would be split up into multiple members for different checks to bypass as well as other options.

Then I can get rid of the launchGameViaSteam function and just make it some bool passed to backend. In fact, the backend has already been adjusted for this ^^

The goal is to have something like this, where different options for how to launch Northstar could be set.

image

Maybe even extended with some degree of launch args, primarily focused on dev stuff, so more towards #449 and less #301 (although the same object could be extended to pass launch args ^^

Requires:

Part of:

@GeckoEidechse
Copy link
Member Author

GeckoEidechse commented Jan 19, 2024

Requesting review from @Alystrasz cause it's been a while since I last wrote TypeScript and I feel like I'm using rather primitive patterns that probably have a smarter way of doing things ^^"

Currently object only has a single member for bypassing all checks.
In the future this would be split up into multiple members for different checks to bypass as well as other options.
@GeckoEidechse GeckoEidechse force-pushed the refactor/pass-launch-options-object branch from c499094 to b00fbee Compare January 19, 2024 14:25
src-vue/src/plugins/store.ts Outdated Show resolved Hide resolved
@GeckoEidechse GeckoEidechse marked this pull request as draft February 12, 2024 01:14
@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Feb 12, 2024
@GeckoEidechse GeckoEidechse marked this pull request as ready for review February 12, 2024 23:55
@GeckoEidechse
Copy link
Member Author

This should be ready for re-review now ^^

Copy link
Member Author

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In quick testing on Linux I can confirm that the changed front-end logic for launching via Steam and with bypassing checks still works.

Cannot test the standard play button atm though...

@github-actions github-actions bot removed the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Feb 12, 2024
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed, confirmed working in testing.

@GeckoEidechse GeckoEidechse merged commit 5a6dd62 into main Feb 21, 2024
14 checks passed
@GeckoEidechse GeckoEidechse deleted the refactor/pass-launch-options-object branch February 21, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants