-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Pass launch options via object #760
Conversation
Requesting review from @Alystrasz cause it's been a while since I last wrote TypeScript and I feel like I'm using rather primitive patterns that probably have a smarter way of doing things ^^" |
Currently object only has a single member for bypassing all checks. In the future this would be split up into multiple members for different checks to bypass as well as other options.
c499094
to
b00fbee
Compare
This should be ready for re-review now ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In quick testing on Linux I can confirm that the changed front-end logic for launching via Steam and with bypassing checks still works.
Cannot test the standard play button atm though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments addressed, confirmed working in testing.
Currently object only has a single member for bypassing all checks. In the future this would be split up into multiple members for different checks to bypass as well as other options.
Then I can get rid of the
launchGameViaSteam
function and just make it some bool passed to backend. In fact, the backend has already been adjusted for this ^^The goal is to have something like this, where different options for how to launch Northstar could be set.
Maybe even extended with some degree of launch args, primarily focused on dev stuff, so more towards #449 and less #301 (although the same object could be extended to pass launch args ^^
Requires:
Part of: