Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support installing Thunderstore packages #426

Merged
merged 11 commits into from
Jul 21, 2023

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Jul 18, 2023

Part of #415

@GeckoEidechse GeckoEidechse marked this pull request as draft July 18, 2023 12:18
@GeckoEidechse GeckoEidechse mentioned this pull request Jul 18, 2023
@GeckoEidechse GeckoEidechse marked this pull request as ready for review July 20, 2023 00:21
@GeckoEidechse
Copy link
Member Author

For testing I used

  • Alystrasz-Parkour-0.1.1 as a mod that should pass instal
  • ScureX-ModCreator-1.0.0 as a mod that should fail install

@GeckoEidechse
Copy link
Member Author

Also tested updating an existing mod where a newer version is broken. It correctly didn't install new version and it kept old version.

@GeckoEidechse
Copy link
Member Author

CI error is due to clippy due to libthermite marking certain functions as deprecated early. Will look into how to best address but shouldn't prevent actually testing ^^"

Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitting missing documentation, the feature works as expected (both in installing correcly-formatted mods and preventing install badly-formatted ones) on Windows 10 and Ubuntu 23.04.

@GeckoEidechse GeckoEidechse merged commit 672ee8e into main Jul 21, 2023
14 checks passed
@GeckoEidechse GeckoEidechse deleted the feat/install-packages branch July 21, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants