-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support installing Thunderstore packages #426
Conversation
also deletes old version of legacy package if installed
For testing I used
|
Also tested updating an existing mod where a newer version is broken. It correctly didn't install new version and it kept old version. |
CI error is due to clippy due to libthermite marking certain functions as deprecated early. Will look into how to best address but shouldn't prevent actually testing ^^" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omitting missing documentation, the feature works as expected (both in installing correcly-formatted mods and preventing install badly-formatted ones) on Windows 10 and Ubuntu 23.04.
The difference is simply the removed deprecation notice
if parsing folder name to Thunderstore mod string failed.
packages
directory #417 first cause otherwise installed mods cannot be read.Wait for libthermite stabilisationCurrent version seems stable enoughPart of #415