Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle error when Northstar download fails #224

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Handle error when Northstar download fails #224

wants to merge 4 commits into from

Conversation

GeckoEidechse
Copy link
Member

In case of download failure return an error message.

Should resolve https://northstar-kv.sentry.io/issues/4014183248/

image

@GeckoEidechse
Copy link
Member Author

Sentry doesn't let me link Sentry<->GitHub issues without a subscription which costs 20$+ a month >:(

@GeckoEidechse GeckoEidechse added the bug Something isn't working label Mar 21, 2023
@Alystrasz
Copy link
Contributor

Alystrasz commented May 4, 2023 •
edited
Loading

What is the expected behaviour of download failure?
I tried to provoke a crash shutting down my Internet connection during a forced reinstall, but only got an "Unable to open zip archive" error message, both with main and this branch.

@GeckoEidechse
Copy link
Member Author

What is the expected behaviour of download failure?

It should be Failed downloading Northstar <error message here>

I tried to provoke a crash shutting down my Internet connection during a forced reinstall, but only got an "Unable to open zip archive" error message, both with main and this branch.

Did it maybe download too fast so by the time you disconnected the connection the download already finished? Although that wouldn't explain the error regarding opening the zip file...

@github-actions github-actions bot added the merge conflicts Blocked by merge conflicts, waiting on the author to resolve label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working merge conflicts Blocked by merge conflicts, waiting on the author to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeckoEidechse @Alystrasz