Fix Match Stats Tracking Improperly #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
Zanieon
commented
Oct 30, 2024
|
@Zanieon already tested this himself, so I'm fine with merging this without further testing. |
GeckoEidechse
removed
the
needs testing
ASpoonPlaysGames
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current method used by registering the stats from the WinnerDetermined gamestate callback would make modes that relies on rounds to register every round as a whole match played, duplicating and stacking the stats registered several times for the same map.
I currently changed where the hook happens so this ensures the stats will register only once and only when the match really ends, still disconsidering Epilogue state.