Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI error when leaving the lobby too quickly #887

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Fix UI error when leaving the lobby too quickly #887

merged 9 commits into from
Nov 18, 2024

Conversation

NachosChipeados
Copy link
Contributor

@NachosChipeados NachosChipeados commented Oct 2, 2024 •
edited by GeckoEidechse
Loading

Fixes #849, using the fix suggested by @Jan200101

How to test:

  1. Click "Launch Northstar"
  2. When the lobby starts loading and you can see you character, immediately press "right arrow + space", to join a private match.
    Without this pr, the game would kick you to the main menu. With this pr, no kick

Before:
https://github.com/user-attachments/assets/2447566b-68ae-4be5-8f22-35b45b7c094b

After:
https://github.com/user-attachments/assets/b59a50b7-ec12-4df5-82a5-78ed66769c70

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Oct 2, 2024
@GeckoEidechse
Copy link
Member

cc @Bobbyperson you might be able to verify this 👀

@Bobbyperson
Copy link
Contributor

yippie!!! i'll test when i get home

@Zanieon
Copy link
Contributor

Zanieon commented Oct 3, 2024

Sorry but this fix is not the way to solve #849 i addressed it to myself because the problem does not lie in the sh_loadouts script, it lies in how @ASpoonPlaysGames wrote the sh_progression script, this error comes from a threaded function that waits a solid second before registering the persistent loadouts, the validity check needs to be put in there.

Zanieon
Zanieon approved these changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@Zanieon Zanieon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@Zanieon Zanieon added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs code review Changes from PR still need to be reviewed in code labels Nov 16, 2024
@GeckoEidechse
Copy link
Member

@NachosChipeados I assume you retested your PR after making the changes @Zanieon proposed?

@NachosChipeados
Copy link
Contributor Author

Yes, and it still works

Titanfall.2.2024-11-17.19-32-05.mp4

@Zanieon Zanieon added READY TO MERGE This mergeable right now and removed needs testing Changes from the PR still need to be tested almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge labels Nov 18, 2024
@GeckoEidechse
Copy link
Member

Aight, Imma just say we skip waiting for anyone else to test this and just merge directly to not stall the PR for too long ^^

@GeckoEidechse GeckoEidechse merged commit 316ec34 into R2Northstar:main Nov 18, 2024
3 checks passed
@NachosChipeados NachosChipeados deleted the connecting_ui_error branch November 18, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames left review comments

@JMM889901 JMM889901 JMM889901 requested changes

@Zanieon Zanieon Zanieon approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Error after being kicked by NSDisconnectPlayer during loading screen
6 participants
@NachosChipeados @GeckoEidechse @Bobbyperson @Zanieon @JMM889901 @ASpoonPlaysGames