Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "improve fastball respawn logic" #171

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

GeckoEidechse
Copy link
Member

Reverts 050e707 as it caused two separate issues (#169 and #170)

@GeckoEidechse
Copy link
Member Author

Will also undo one of the completed tasks of #132

But now we at least know that it can cause some regressions :P

@BobTheBob9
Copy link
Member

i think this is an issue with the change to SetControlPanelUseFunc for panel hacks, i'd prefer to figure out why this is has introduced the bug rather than reverting the whole thing

@GeckoEidechse
Copy link
Member Author

GeckoEidechse commented Jan 28, 2022

Usually I'd agree but as that one commit introduced two separate regressions I'd argue it makes more sense to revert it and then re-add the two changes under proper testing one commit at a time.

Your call though ¯\_(ツ)_/¯

@laundmo
Copy link
Member

laundmo commented Jan 29, 2022

theres a third regression: the B spot on glitch spawns ppl in the water, instantly killing them. please revert until a solution can be found that doesnt cause these issues.


@BobTheBob9
Copy link
Member

aight sure i'll revert for now and try to get a more robust version of these changes pushed soon

@BobTheBob9 BobTheBob9 merged commit 0fe2438 into main Jan 29, 2022
@GeckoEidechse GeckoEidechse deleted the revert-improve-fastball-respawn-logic branch January 29, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants