-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH -- Bump Supported Python Versions to 3.9+ #101
base: master
Are you sure you want to change the base?
Conversation
I recognize Python 3.13 is still relatively new and some packages, e.g., EditI removed Python 3.13 from the workflow. |
- Removed 3.6, 3.7, and 3.8 from `matrix.python-version` and added 3.10, 3.11, 3.12, and 3.13. modified: README.md - Changed supported Python versions from 3.6+ to 3.9+.
I'm running local tests to see if the package will build on the new versions. On Python 3.10, FAILED contextualSpellCheck/tests/test_contextualSpellCheck.py::test_vocab_file - UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 13373: character maps to <undefined>
I can get past the error by changing the following line, but this still results in a failed test. - with open(orgDebugFilePath) as f1:
+ with open(orgDebugFilePath, encoding="latin1") as f1: Taking a step back, what is the purpose of the following assert statement? def test_vocab_file():
...
with open(orgDebugFilePath) as f1:
with open(debugPathFile) as f2:
assert f1.read() == f2.read() EditI understand now—you're checking that the I was able to get the test ( |
- Set `encoding="utf8"` in :method:`ContextualSpellCheck.__init__` when `debug=True` to resolve failing unit test, :callable:`test_vocab_file`. modified: contextualSpellCheck/tests/test_contextualSpellCheck.py - Set `encoding="utf8"` in test :callable:`test_vocab_file` to match encoding in :method:`ContextualSpellCheck.__init__` when `debug=True` allowing test to pass.
ef7f2bd
to
6f8bde1
Compare
- Formatted with black.
- Removed 3.13 as the spacy whl file cannot be built yet. See explosion/srsly#112 for details.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@R1j1t bump |
Description
Checklist