Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes an issue with missing duals for spaces in fusers. #184

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Fixes an issue with missing duals for spaces in fusers. #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3c5a17
Fix dual spaces in fusers
lkdvos Oct 26, 2024
c2abf5a
Make `DenseMPO` to `TensorMap` converter work for symmetry
lkdvos Oct 26, 2024
2df18aa
Expand tests to include `FiniteMPO` with symmetry
lkdvos Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/operators/densempo.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,12 @@ function Base.convert(::Type{<:AbstractTensorMap}, mpo::FiniteMPO)
U_right = Tensor(ones, scalartype(mpo), V_right')

tensors = vcat(U_left, mpo.opp, U_right)
indices = [[i, -i, -(i + N), i + 1] for i in 1:length(mpo)]
indices = [[i, -i, -(2N - i + 1), i + 1] for i in 1:length(mpo)]
pushfirst!(indices, [1])
push!(indices, [N + 1])
O = ncon(tensors, indices)

return transpose(O, (ntuple(identity, N), ntuple(i -> i + N, N)))
return transpose(O, (ntuple(identity, N), ntuple(i -> 2N - i + 1, N)))
end

# Linear Algebra
Expand Down Expand Up @@ -210,7 +210,8 @@ function Base.:*(mpo1::FiniteMPO{TO}, mpo2::FiniteMPO{TO}) where {TO}
Fₗ = i != 1 ? Fᵣ :
isomorphism(A, fuse(left_virtualspace(mpo2, i), left_virtualspace(mpo1, i)),
left_virtualspace(mpo2, i) * left_virtualspace(mpo1, i))
Fᵣ = isomorphism(A, fuse(right_virtualspace(mpo2, i), right_virtualspace(mpo1, i)),
Fᵣ = isomorphism(A,
fuse(right_virtualspace(mpo2, i)', right_virtualspace(mpo1, i)'),
right_virtualspace(mpo2, i)' * right_virtualspace(mpo1, i)')

@plansor O[i][-1 -2; -3 -4] := Fₗ[-1; 1 4] * mpo2[i][1 2; -3 3] *
Expand All @@ -232,7 +233,7 @@ function Base.:*(mpo::FiniteMPO, mps::FiniteMPS)
Fₗ = i != 1 ? Fᵣ :
isomorphism(TT, fuse(left_virtualspace(A[i]), left_virtualspace(mpo, i)),
left_virtualspace(A[i]) * left_virtualspace(mpo, i))
Fᵣ = isomorphism(TT, fuse(right_virtualspace(A[i]), right_virtualspace(mpo, i)),
Fᵣ = isomorphism(TT, fuse(right_virtualspace(A[i])', right_virtualspace(mpo, i)'),
right_virtualspace(A[i])' * right_virtualspace(mpo, i)')
@plansor A[i][-1 -2; -3] := Fₗ[-1; 1 3] * A[i][1 2; 4] *
mpo[i][3 -2; 2 5] *
Expand Down
54 changes: 29 additions & 25 deletions test/operators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,39 +19,43 @@ vspaces = (ℙ^10, Rep[U₁]((0 => 20)), Rep[SU₂](1 // 2 => 10, 3 // 2 => 5, 5
@testset "FiniteMPO" begin
# start from random operators
L = 4
O₁ = TensorMap(rand, ComplexF64, (ℂ^2)^L, (ℂ^2)^L)
O₂ = TensorMap(rand, ComplexF64, space(O₁))
T = ComplexF64

# create MPO and convert it back to see if it is the same
mpo₁ = FiniteMPO(O₁) # type-unstable for now!
mpo₂ = FiniteMPO(O₂)
@test convert(TensorMap, mpo₁) ≈ O₁
@test convert(TensorMap, -mpo₂) ≈ -O₂
for V in (ℂ^2, U1Space(0 => 1, 1 => 1))
O₁ = TensorMap(rand, T, V^L, V^L)
O₂ = TensorMap(rand, T, space(O₁))

# test scalar multiplication
α = rand(ComplexF64)
@test convert(TensorMap, α * mpo₁) ≈ α * O₁
@test convert(TensorMap, mpo₁ * α) ≈ O₁ * α
# create MPO and convert it back to see if it is the same
mpo₁ = FiniteMPO(O₁) # type-unstable for now!
mpo₂ = FiniteMPO(O₂)
@test convert(TensorMap, mpo₁) ≈ O₁
@test convert(TensorMap, -mpo₂) ≈ -O₂

# test addition and multiplication
@test convert(TensorMap, mpo₁ + mpo₂) ≈ O₁ + O₂
@test convert(TensorMap, mpo₁ * mpo₂) ≈ O₁ * O₂
# test scalar multiplication
α = rand(T)
@test convert(TensorMap, α * mpo₁) ≈ α * O₁
@test convert(TensorMap, mpo₁ * α) ≈ O₁ * α

# test application to a state
ψ₁ = Tensor(rand, ComplexF64, domain(O₁))
mps₁ = FiniteMPS(ψ₁)
# test addition and multiplication
@test convert(TensorMap, mpo₁ + mpo₂) ≈ O₁ + O₂
@test convert(TensorMap, mpo₁ * mpo₂) ≈ O₁ * O₂

@test convert(TensorMap, mpo₁ * mps₁) ≈ O₁ * ψ₁
# test application to a state
ψ₁ = Tensor(rand, T, domain(O₁))
mps₁ = FiniteMPS(ψ₁)

@test dot(mps₁, mpo₁, mps₁) ≈ dot(ψ₁, O₁, ψ₁)
@test dot(mps₁, mpo₁, mps₁) ≈ dot(mps₁, mpo₁ * mps₁)
# test conversion to and from mps
mpomps₁ = convert(FiniteMPS, mpo₁)
mpompsmpo₁ = convert(FiniteMPO, mpomps₁)
@test convert(TensorMap, mpo₁ * mps₁) ≈ O₁ * ψ₁

@test convert(FiniteMPO, mpomps₁) ≈ mpo₁ rtol = 1e-6
@test dot(mps₁, mpo₁, mps₁) ≈ dot(ψ₁, O₁, ψ₁)
@test dot(mps₁, mpo₁, mps₁) ≈ dot(mps₁, mpo₁ * mps₁)
# test conversion to and from mps
mpomps₁ = convert(FiniteMPS, mpo₁)
mpompsmpo₁ = convert(FiniteMPO, mpomps₁)

@test dot(mpomps₁, mpomps₁) ≈ dot(mpo₁, mpo₁)
@test convert(FiniteMPO, mpomps₁) ≈ mpo₁ rtol = 1e-6

@test dot(mpomps₁, mpomps₁) ≈ dot(mpo₁, mpo₁)
end
end

@testset "Finite MPOHamiltonian" begin
Expand Down
Loading