-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine pr #182
Combine pr #182
Conversation
3 site tests
comitted to properly named branch
3 site tests
made VUMPSSVD parallel as well !
formatted lol...
I'm gonna do my best to get to all of this and look at everything as soon as possible, I'm a bit short on time these days. (Moving houses, traveling and preparing presentations seem to be taken up a lot of time...) |
Codecov ReportAttention: Patch coverage is
|
Hi, Thanks for the quick reply. I wouldn't say its super urgent, but on the other hand, for my usecase with unit cell 32 this should amount to a HUGE speed increase. I guess I can always use my local branch though. I don't like doing this though. Ps : a lot of the commits are me forgetting to format. Or fixing typos. The actual amount of new code is quite minimal. |
@lkdvos seems like you've already reviewed the other PRs so this is irrelevant now. As you suggested the best way forward is probably to first merge the tests and then the other two PRs ! |
In case it's more convenient for the main devs (I guess @lkdvos ), this PR merges my three prior PRs into one.
So in this PR I've combined
Most notably the new tests seemed important for me since the parallel GD and VumpsSvd might only fail when multiple sites are present and the parallel code kicks in...
At the very least this PR allows the reviewer to see that the new code works with the new tests :)
It's equivalent to merge this PR or merge the 3 previous PRs that I just did :)
Like I said, whatever is most convenient...