Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR makes GD paralellize over sites #178

Closed
wants to merge 2 commits into from

Conversation

Gertian
Copy link
Collaborator

@Gertian Gertian commented Oct 15, 2024

To remarks :

  1. I failed to paralelize
function retract(x::ManifoldPoint{<:FiniteMPS}, g, alpha)
    #TODO : support parralelize_sites.
    state = x.state
    envs = x.envs

    y = copy(state)  # The end-point
    h = similar(g)  # The tangent at the end-point
    for i in 1:length(g)
        yal, th = Grassmann.retract(state.AL[i], g[i].Pg, alpha)
        h[i] = PrecGrad(th)
        y.AC[i] = (yal, state.CR[i])
    end
    normalize!(y)

    n_y = ManifoldPoint(y, envs)

    return n_y, h
end

2)I don't think there are explicit tests for multi-site unit cells. Is this something that should be added ?

@Gertian Gertian requested a review from lkdvos October 15, 2024 13:27
@Gertian
Copy link
Collaborator Author

Gertian commented Oct 15, 2024

Ok I'm sorry for the mess.
I'm trying to do another PR at the same time so I need to give this one a better name.

In fact I should have done that in the first place...

Remaking this with better name :)

@Gertian Gertian closed this Oct 15, 2024
@Gertian Gertian removed the request for review from lkdvos October 15, 2024 13:43
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/algorithms/grassmann.jl 76.19% 10 Missing ⚠️
Files with missing lines Coverage Δ
src/algorithms/grassmann.jl 92.95% <76.19%> (-7.05%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant